Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find spaces #5044

Merged
merged 4 commits into from
Nov 15, 2022
Merged

Find spaces #5044

merged 4 commits into from
Nov 15, 2022

Conversation

aduffeck
Copy link
Contributor

This PR fixes finding spaces by their name in the search service.

Fixes #4506

@ownclouders
Copy link
Contributor

💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

@micbar
Copy link
Contributor

micbar commented Nov 11, 2022 

runsh: There were no unexpected failures.
runsh: Total unexpected passed scenarios throughout the test run:
apiSpaces/search.feature:96

@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@butonic butonic merged commit 60b979d into owncloud:master Nov 15, 2022
@butonic butonic deleted the find-spaces branch November 15, 2022 15:53
ownclouders pushed a commit that referenced this pull request Nov 15, 2022
@aduffeck
commit 60b979d
be4862c 
Author: Andre Duffeck <[email protected]>
Date:   Tue Nov 15 16:52:55 2022 +0100

    Find spaces (#5044)

    * Use the node name for the name field in the index instead of the path

    * Add changelog

    * Fix tests

    * Adapt expected failures
@micbar micbar mentioned this pull request Nov 25, 2022
Closed
73 tasks
@ScharfViktor ScharfViktor mentioned this pull request Nov 28, 2022
Closed
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

search doesn't find the project space by name
4 participants
@aduffeck @ownclouders @micbar @butonic