Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow initial self-assignemnt of UserRole #5065

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Nov 16, 2022

When using an external user management we need to allow users to self-assign the default role. This adds an explicit check for that to the settings service. This also means we no longer need to fiddle with the account id in the proxy upon first login.

Fixes: #5045

@rhafer rhafer self-assigned this Nov 16, 2022
@ownclouders

This comment was marked as resolved.

When using an external user management we need to allow users to self-assign
the default role. This adds an explicit check for that to the settings service.
This also means we no longer need to fiddle with the account id in the proxy
upon first login.

Fixes: owncloud#5045
@sonarcloud
Copy link

sonarcloud bot commented Nov 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

77.8% 77.8% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micbar micbar merged commit e2c7b3f into owncloud:master Nov 21, 2022
ownclouders pushed a commit that referenced this pull request Nov 21, 2022
Merge: ce54ae5 07a7828
Author: Michael Barz <[email protected]>
Date:   Mon Nov 21 12:11:34 2022 +0100

    Merge pull request #5065 from rhafer/issue/5045

    Allow initial self-assignemnt of UserRole
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rc.1 external OIDC+LDAP setup, error on new user first login
3 participants