Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omitempty givenName attribute when create user #5431 #6259

Merged
merged 1 commit into from
May 10, 2023

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented May 9, 2023

Description

Related Issue

How Has This Been Tested?

  • test environment: local, curl
  • test case 1:
curl -k -X 'POST' -u admin:admin  'https://localhost:9200/graph/v1.0/users' --data '{ "onPremisesSamAccountName": "test1", "displayName":"test1", "mail":"[email protected]"}' | jq .

{
  "displayName": "test1",
  "id": "681dca41-b674-49f6-84c2-5ebf48b92851",
  "mail": "[email protected]",
  "onPremisesSamAccountName": "test1",
  "surname": "test1",
  "userType": "Member"
}

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@2403905 2403905 marked this pull request as ready for review May 9, 2023 15:12
@2403905 2403905 requested review from kobergj and rhafer May 9, 2023 15:37
@2403905 2403905 merged commit 21dfe2d into owncloud:master May 10, 2023
ownclouders pushed a commit that referenced this pull request May 10, 2023
Omitempty givenName attribute when create user #5431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graph: create user, empty givenName attribute
2 participants