-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] enhancement: use reva client pool selectors #6452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
fschade
force-pushed
the
reva-selector-pool
branch
from
June 7, 2023 13:13
2bb7cd3
to
0835b32
Compare
fschade
force-pushed
the
reva-selector-pool
branch
from
June 7, 2023 13:26
0835b32
to
055ca8f
Compare
register mock service to registry and pass tests
fschade
force-pushed
the
reva-selector-pool
branch
from
June 7, 2023 19:41
f012366
to
3d6191b
Compare
E2E tests failed: https://drone.owncloud.com/owncloud/ocis/23080/90/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/23080/tracing/members-of-the-space-can-control-the-versions-of-the-files-alice-2023-6-7-09-38-28.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/23080/tracing/public-link-for-space-alice-2023-6-7-09-38-34.zip |
fschade
changed the title
enhancement: use reva client pool selectors
[full-ci] enhancement: use reva client pool selectors
Jun 7, 2023
fschade
requested review from
wkloucek,
micbar,
phil-davis and
individual-it
as code owners
June 7, 2023 22:12
fschade
force-pushed
the
reva-selector-pool
branch
from
June 7, 2023 22:22
d3b438a
to
31178b2
Compare
butonic
approved these changes
Jun 8, 2023
rhafer
force-pushed
the
reva-selector-pool
branch
from
June 8, 2023 08:49
7ca2e63
to
0ecb240
Compare
SonarCloud Quality Gate failed. |
ownclouders
pushed a commit
that referenced
this pull request
Jun 8, 2023
* enhancement: use reva client pool selectors register mock service to registry and pass tests * enhancement: bump reva * Fix a couple of linter issues --------- Co-authored-by: Ralf Haferkamp <[email protected]>
fschade
added a commit
that referenced
this pull request
Jul 10, 2023
* enhancement: use reva client pool selectors register mock service to registry and pass tests * enhancement: bump reva * Fix a couple of linter issues --------- Co-authored-by: Ralf Haferkamp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use reva client selectors instead of the static clients, this introduces the ocis service registry in reva.
The service discovery now resolves reva services by name and the client selectors pick a random registered service node.