Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the app provider service name configurable #6482

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Jun 8, 2023

Description

We needed to make the service name of the app provider configurable. This needs to be changed when using more than one app provider. Each of them needs be afound by a unique service name. Possible examples are: app-provider-collabora, app-provider-onlyoffice, app-provider-office365.

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jun 8, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar micbar marked this pull request as ready for review June 8, 2023 19:45
@micbar micbar requested review from dj4oC and butonic June 8, 2023 19:45
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@micbar micbar merged commit e7a31a0 into master Jun 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-app-provider-config branch June 8, 2023 20:16
ownclouders pushed a commit that referenced this pull request Jun 8, 2023
make the app provider service name configurable
@micbar micbar mentioned this pull request Jun 8, 2023
13 tasks
@micbar micbar mentioned this pull request Jul 24, 2023
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants