Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Retry Postprocessing #6500

Merged
merged 4 commits into from
Jun 14, 2023
Merged

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Jun 12, 2023

Adds a ctl command to retry failed postprocessing by upload id

Fixes #6495

If postprocessing fails in one step due to an unforseen error, current uploads will not be retried automatically. A system admin can instead run a CLI command to retry the failed upload which is a two step process:

- First find the upload ID of the failed upload.
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant make a suggestion...
You need to add post the three ticks the term bash to silence the remaining codacy complain.
The same on the next cli command.

@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kobergj kobergj marked this pull request as ready for review June 13, 2023 09:35
@wkloucek
Copy link
Contributor

@kobergj would it make sense to run this periodically (eg. via cronjob)?

@kobergj
Copy link
Collaborator Author

kobergj commented Jun 13, 2023

@wkloucek yes this is possible. It would need a little scripting as one needs to get the list of unfinished uploads via ocis storage-users uploads list first. But no magic.

I guess it is more a question to PMs if we want it like this.

@wkloucek
Copy link
Contributor

@wkloucek yes this is possible. It would need a little scripting as one needs to get the list of unfinished uploads via ocis storage-users uploads list first. But no magic.

I guess it is more a question to PMs if we want it like this.

Ok, so you do think that it actually makes sense to run this on a schedule even if one doesn't need this to be run on a regular basis under normal circumstances? Could this do potential harm (eg. race conditions?)?

@kobergj
Copy link
Collaborator Author

kobergj commented Jun 13, 2023

It will put extra load on the server if you retry the postprocessing of a file that is currently in postprocessing. E.g. there might be two virus scans for the same file at the same time. So it's best to only retry uploads that are stuck. However it would do no harm except the extra load and maybe some not found messages of the second process.

Copy link
Contributor

@rhafer rhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kobergj kobergj merged commit 613500c into owncloud:master Jun 14, 2023
@kobergj kobergj deleted the PostprocessingRetries branch June 14, 2023 08:45
ownclouders pushed a commit that referenced this pull request Jun 14, 2023
@micbar micbar mentioned this pull request Jul 24, 2023
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed postprocessing does not retry
4 participants