-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Retry Postprocessing #6500
Conversation
3b5eced
to
4f4d04d
Compare
services/postprocessing/README.md
Outdated
If postprocessing fails in one step due to an unforseen error, current uploads will not be retried automatically. A system admin can instead run a CLI command to retry the failed upload which is a two step process: | ||
|
||
- First find the upload ID of the failed upload. | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cant make a suggestion...
You need to add post the three ticks the term bash
to silence the remaining codacy complain.
The same on the next cli command.
4f4d04d
to
987ddfa
Compare
Signed-off-by: jkoberg <[email protected]>
Signed-off-by: jkoberg <[email protected]>
Signed-off-by: jkoberg <[email protected]>
Signed-off-by: jkoberg <[email protected]>
987ddfa
to
8635670
Compare
Kudos, SonarCloud Quality Gate passed! |
@kobergj would it make sense to run this periodically (eg. via cronjob)? |
@wkloucek yes this is possible. It would need a little scripting as one needs to get the list of unfinished uploads via I guess it is more a question to PMs if we want it like this. |
Ok, so you do think that it actually makes sense to run this on a schedule even if one doesn't need this to be run on a regular basis under normal circumstances? Could this do potential harm (eg. race conditions?)? |
It will put extra load on the server if you retry the postprocessing of a file that is currently in postprocessing. E.g. there might be two virus scans for the same file at the same time. So it's best to only retry uploads that are stuck. However it would do no harm except the extra load and maybe some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
[full-ci] Retry Postprocessing
Adds a ctl command to retry failed postprocessing by upload id
Fixes #6495