Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

OcModal: Add checkbox and secondary button #2149

Merged
merged 5 commits into from
May 30, 2022
Merged

OcModal: Add checkbox and secondary button #2149

merged 5 commits into from
May 30, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented May 19, 2022 •
edited
Loading

Description

We've added an optional checkbox and secondary button to the OcModal

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added/updated

@update-docs
Copy link

update-docs bot commented May 19, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat mentioned this pull request May 20, 2022
Merged
1 task
kulmann
kulmann suggested changes May 20, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need additional props? Is it not feasible to implement a component API that uses inputType="checkbox"?

src/components/organisms/OcModal/OcModal.vue Show resolved Hide resolved
src/components/organisms/OcModal/OcModal.vue Outdated Show resolved Hide resolved
@lookacat lookacat changed the title Add Checkbox to OcModal Add checkbox and secondary button to OcModal May 24, 2022
@lookacat
Copy link
Contributor Author

inputType seems to be very bound to oc-text-input, also would argue that you may want an text input with a checkbox

@lookacat lookacat marked this pull request as ready for review May 24, 2022 12:45
@lookacat lookacat changed the title Add checkbox and secondary button to OcModal OcModal: Add checkbox and secondary button May 24, 2022
@lookacat lookacat requested a review from kulmann May 24, 2022 12:45
@lookacat lookacat requested a review from dschmidt May 25, 2022 07:59
@sonarcloud
Copy link

sonarcloud bot commented May 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes May 30, 2022
View reviewed changes
src/components/organisms/OcModal/OcModal.vue
v-model="checkboxValue"
size="medium"
:label="checkboxLabel"
:aria-label="checkboxLabel"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if aria-label and accessible content (in this case: label) are the same you don't need the aria-label. You can drop it completely.

@lookacat lookacat merged commit 1198730 into master May 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-oc-modal-checkbox branch May 30, 2022 11:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload of folder with same name shows error
3 participants
@lookacat @dschmidt @kulmann