Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check dependencies like PHP version before the upgrade #107

Closed
ghost opened this issue Mar 26, 2015 · 6 comments
Closed

Check dependencies like PHP version before the upgrade #107

ghost opened this issue Mar 26, 2015 · 6 comments

Comments

@ghost
Copy link

ghost commented Mar 26, 2015

Hi,

currently hard dependencies like PHP 5.4 are only checked in core:

https://github.com/owncloud/core/blob/v8.0.2/lib/private/util.php#L622-L629

Especially in the case of an upgrade from a system running OC 7.x with PHP 5.3 to OC 8.x this caused a failure of the upgrade. User often just miss to read this new dependency in the documentation and so they are stuck with a new OC8 upgrade which forces them either to roll-back an backup or to upgrade their PHP.

As the updater from OC7 for example can't know what new dependencies OC8 will bring maybe the API on https://apps.owncloud.com/updater.php?version=4x90x14x1338030373.1628x1373617342.3379xstablex could be extended to show such problematic new dependencies like PHP 5.4. This could be used by the updater app to warn the user before doing the upgrade.

@ghost
Copy link
Author

ghost commented Apr 1, 2015

Hi,

i think this is getting more importance for the OC 8.1 release which should include owncloud/core#14540. On windows this will hard-fail, don't want to know how many installations are "stuck" with that if a windows user is just clicking on "update". 🙈

@aznewt
Copy link

aznewt commented Apr 6, 2015

Indeed, this happened to me last night: didn't read the dependencies, clicked update, installed 8.0.2 on my php 5.3.24 hosting plan. I don't have a 7.x database backup so now having to figure out how to get back to 7.x

Please give ths enhancement ahigh priority!

@VicDeo
Copy link
Member

VicDeo commented May 5, 2015

@karlitschek On my opinion PHP version check is needed for OC7 only since PHP 5.4 is a hard requirement for OC8 so we can skip this for master/stable8.

I suggest to hide the content of the entire 'Update' section in this case and show a warning:
"Your server environment is not compatible with ownCloud 8. You need to update PHP to the version 5.4.0 or above".
What do you think?

@karlitschek
Copy link

@VicDeo Good idea :-)

VicDeo added a commit that referenced this issue May 6, 2015
VicDeo added a commit that referenced this issue May 11, 2015
Check PHP version before update. Closes #107
@VicDeo
Copy link
Member

VicDeo commented May 25, 2015

OC8 and PHP 5.3 #117
win and 8.1 #118

@tflidd
Copy link

tflidd commented Jun 19, 2015

Would be nice to have a check if all the apps are available for the new version (during upgrades).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants