-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check dependencies like PHP version before the upgrade #107
Comments
Hi, i think this is getting more importance for the OC 8.1 release which should include owncloud/core#14540. On windows this will hard-fail, don't want to know how many installations are "stuck" with that if a windows user is just clicking on "update". 🙈 |
Indeed, this happened to me last night: didn't read the dependencies, clicked update, installed 8.0.2 on my php 5.3.24 hosting plan. I don't have a 7.x database backup so now having to figure out how to get back to 7.x Please give ths enhancement ahigh priority! |
@karlitschek On my opinion PHP version check is needed for OC7 only since PHP 5.4 is a hard requirement for OC8 so we can skip this for master/stable8. I suggest to hide the content of the entire 'Update' section in this case and show a warning: |
@VicDeo Good idea :-) |
Check PHP version before update. Closes #107
Would be nice to have a check if all the apps are available for the new version (during upgrades). |
Hi,
currently hard dependencies like PHP 5.4 are only checked in core:
https://github.com/owncloud/core/blob/v8.0.2/lib/private/util.php#L622-L629
Especially in the case of an upgrade from a system running OC 7.x with PHP 5.3 to OC 8.x this caused a failure of the upgrade. User often just miss to read this new dependency in the documentation and so they are stuck with a new OC8 upgrade which forces them either to roll-back an backup or to upgrade their PHP.
As the updater from OC7 for example can't know what new dependencies OC8 will bring maybe the API on https://apps.owncloud.com/updater.php?version=4x90x14x1338030373.1628x1373617342.3379xstablex could be extended to show such problematic new dependencies like PHP 5.4. This could be used by the updater app to warn the user before doing the upgrade.
The text was updated successfully, but these errors were encountered: