Skip to content

Commit

Permalink
Merge pull request #6863 from owncloud/stripp-integration-tests
Browse files Browse the repository at this point in the history
Remove integration tests
  • Loading branch information
kulmann authored May 3, 2022
2 parents fa3c71c + df6ef07 commit 82c5978
Show file tree
Hide file tree
Showing 15 changed files with 26 additions and 1,270 deletions.
11 changes: 1 addition & 10 deletions .drone.star
Original file line number Diff line number Diff line change
Expand Up @@ -1066,7 +1066,7 @@ def unitTests(ctx):
return [{
"kind": "pipeline",
"type": "docker",
"name": "unit-and-integration-tests",
"name": "unit-tests",
"workspace": {
"base": dir["base"],
"path": config["app"],
Expand Down Expand Up @@ -1101,13 +1101,6 @@ def unitTests(ctx):
"yarn test:unit",
],
},
{
"name": "integration-tests",
"image": OC_CI_NODEJS,
"commands": [
"yarn test:integration",
],
},
{
"name": "sonarcloud",
"image": SONARSOURCE_SONAR_SCANNER_CLI,
Expand Down Expand Up @@ -3078,7 +3071,6 @@ def skipIfUnchanged(ctx, type):
"^__fixtures__/.*",
"^__mocks__/.*",
"^packages/.*/tests/.*",
"^tests/integration/.*",
"^tests/e2e/.*",
"^tests/unit/.*",
]
Expand All @@ -3093,7 +3085,6 @@ def skipIfUnchanged(ctx, type):
"^__mocks__/.*",
"^packages/.*/tests/.*",
"^tests/acceptance/.*",
"^tests/integration/.*",
"^tests/unit/.*",
]
skip_step["settings"] = {
Expand Down
6 changes: 6 additions & 0 deletions changelog/unreleased/enhancement-remove-integration-tests
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Enhancement: Get rid of the integration tests

We've decided to get rid of our integration test suite.
Our unit and e2e tests get better and better with each release and have now reached the point where they can replace the integration tests.

https://github.com/owncloud/web/pull/6863
2 changes: 1 addition & 1 deletion docs/development.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Everyone is invited to contribute. Simply fork [the codebase](), check [the issu

### Linting and tests

To make sure your pull request can be efficiently reviewed and won't need a lot of changes down the road, please run the linter and the unit&integration tests via `yarn lint --fix` and `yarn test:unit && yarn test:integration` locally. [Our CI](https://drone.owncloud.com/owncloud/web) will run on pull requests and report back any problems after that. For a further introduction on how we handle testing, please head to the [testing docs]({{< ref "testing/_index.md" >}}).
To make sure your pull request can be efficiently reviewed and won't need a lot of changes down the road, please run the linter and the unit tests via `yarn lint --fix` and `yarn test:unit` locally. [Our CI](https://drone.owncloud.com/owncloud/web) will run on pull requests and report back any problems after that. For a further introduction on how we handle testing, please head to the [testing docs]({{< ref "testing/_index.md" >}}).

### Changelog items

Expand Down
5 changes: 2 additions & 3 deletions docs/testing/testing.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,12 @@ $ cd web
$ yarn
```

### Unit & Integration Tests
### Unit Tests

We have a steadily growing coverage of both unit and integration tests. You can run them locally via
We have a steadily growing coverage of unit tests. You can run them locally via

```shell
$ yarn test:unit
$ yarn test:integration
```

You can also specify which tests to run by giving a path param, like so: `yarn test:unit packages/<app-name>/tests/unit/path/to/test.spec.js`.
Expand Down
8 changes: 2 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
"depcheck": "depcheck",
"lint": "eslint '{packages,tests}/**/*.{js,ts,vue}' --color",
"serve": "SERVER=true yarn build:w",
"test:integration": "jest --config ./tests/integration/config/jest.config.js",
"test:e2e:cucumber": "NODE_TLS_REJECT_UNAUTHORIZED=0 cucumber-js --profile=e2e -f json:tests/e2e/cucumber/report/cucumber_report.json",
"test:unit": "NODE_OPTIONS=--unhandled-rejections=throw jest --coverage --config ./tests/unit/config/jest.config.js",
"licenses:check": "license-checker-rseidelsohn --summary --relativeLicensePath --onlyAllow 'Python-2.0;Apache*;Apache License, Version 2.0;Apache-2.0;Apache 2.0;Artistic-2.0;BSD;BSD-3-Clause;CC-BY-3.0;CC-BY-4.0;CC0-1.0;ISC;MIT;MPL-2.0;Public Domain;Unicode-TOU;Unlicense;WTFPL' --excludePackages 'draw-io;external;files;text-editor;preview;owncloud-design-system;pdf-viewer;search;user-management;web-client;web-pkg;web-runtime'",
Expand Down Expand Up @@ -60,10 +59,6 @@
"@rollup/plugin-inject": "^4.0.4",
"@rollup/plugin-json": "^4.1.0",
"@rollup/plugin-typescript": "^8.3.0",
"@testing-library/dom": "^8.11.0",
"@testing-library/jest-dom": "^5.16.1",
"@testing-library/user-event": "^13.5.0",
"@testing-library/vue": "^5.8.2",
"@types/jest": "^27.4.1",
"@types/jest-axe": "^3.5.3",
"@types/lodash-es": "^4.17.5",
Expand Down Expand Up @@ -136,7 +131,8 @@
"url-search-params-polyfill": "^8.0.0",
"vue-jest": "^3.0.7",
"vue-template-compiler": "^2.6.12",
"vuex-mock-store": "0.0.8"
"vuex-mock-store": "0.0.8",
"wait-for-expect": "^3.0.2"
},
"engines": {
"node": ">=14 <=16"
Expand Down
52 changes: 0 additions & 52 deletions packages/web-app-files/tests/integration/helpers/date.js

This file was deleted.

Loading

0 comments on commit 82c5978

Please sign in to comment.