feat: add docxf icon mapping and fix document icon colors #10037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
requested review from
lookacat,
dragonchaser,
AlexAndBear,
tbsbdr and
JammingBen
tbsbdr
requested changes
Nov 22, 2023
There was a problem hiding this comment.
I suggest to stick to the current colors but with the following changes:
- Forms (new color as already implemented by you)
- MD (dedicated as already implemented by you)
- All other file-extension colors should not change - sorry, this was a misunderstanding. I see no reason to change them. Do you argee?
kulmann
force-pushed
the
document-icons-and-colors
branch
from
9979f6f
to
64f0b56
Compare
Thanks for checking. Updated the PR 👍 |
JammingBen
approved these changes
Nov 23, 2023
kulmann
force-pushed
the
document-icons-and-colors
branch
from
64f0b56
to
2830f2d
Compare
kulmann
force-pushed
the
document-icons-and-colors
branch
from
2830f2d
to
c467aaa
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ownclouders
pushed a commit
that referenced
this pull request
Nov 24, 2023
feat: add docxf icon mapping and fix document icon colors
12 tasks
This was referenced Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup for #9911 - adding the docxf icon mapping and adjusting colors.
Related Issue
Screenshot
Types of changes
Checklist: