[full-ci] Only show batch actions for more than one selected resource #6351
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/22339/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22339/2022-2-1-08-15-40-Alice.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22339/2022-2-1-08-15-46-Brian.zip |
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/22339/10/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22339/2022-2-1-08-16-43-Alice.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22339/2022-2-1-08-16-49-Brian.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22339/2022-2-1-08-17-03-Alice.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22339/2022-2-1-08-17-09-Brian.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22339/2022-2-1-08-17-50-Alice.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22339/2022-2-1-08-17-56-Brian.zip |
|
SonarCloud Quality Gate failed. |
|
Results for oC10SharingAndTrashbin https://drone.owncloud.com/owncloud/web/22340/32/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUITrashbinDelete-trashbinDelete_feature-L99.png |
|
Results for oC10Move https://drone.owncloud.com/owncloud/web/22340/19/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIMoveFilesFolders-moveFiles_feature-L139.png |
|
Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/22340/64/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUITrashbinDelete-trashbinDelete_feature-L99.png |
|
Results for oC10Files5 https://drone.owncloud.com/owncloud/web/22340/18/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIFiles-batchAction_feature-L113.pngwebUIFiles-batchAction_feature-L14.pngwebUIFiles-batchAction_feature-L24.pngwebUIFiles-batchAction_feature-L62.pngwebUIFiles-batchAction_feature-L75.png |
|
Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/22340/56/1
|
|
Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/22340/53/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIFiles-batchAction_feature-L113.pngwebUIFiles-batchAction_feature-L14.pngwebUIFiles-batchAction_feature-L24.pngwebUIFiles-batchAction_feature-L62.pngwebUIFiles-batchAction_feature-L75.png |
|
Needs a rebase once #6358 is merged but should be quite easy to finalize ✊🏽 |
|
Needs a rebase, I'll take care of it today |
pascalwengerter
force-pushed
the
batchactions-select-min-two
branch
3 times, most recently
from
1bc21f3
to
b7c3585
Compare
|
reduces unnecessary changes in the ui - feels really good NEW - what you see in the video: batch actions are only shown, if at least 2 items are selected. i.e. if only 1 item is selected, batch actions are not shown (batch of 1 items doesnt make sense imo)
|
pascalwengerter
force-pushed
the
batchactions-select-min-two
branch
from
b7c3585
to
8078e80
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/26626/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/26626/tracing/unstructured-collection-of-testable-space-interactions-alice-2022-7-4-03-59-06.zip |
|
received positive feedback on the changes :-) lets do it. would be nice, if the Current: proposal with gaps aligned: fyi @ChrisEdS |
pascalwengerter
force-pushed
the
batchactions-select-min-two
branch
from
8078e80
to
5d45b7d
Compare
There was a problem hiding this comment.
@pascalwengerter could you align the gaps of the row as mentioned in
#6351 (comment)
to be more precise:
everything else is fine, thanks!
…bin) and make them appear in raw
pascalwengerter
force-pushed
the
batchactions-select-min-two
branch
from
5d45b7d
to
9b6fbe9
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
@tbsbdr Whats the state here? The batch actions changed meanwhile - they are outlined buttons now, I think that's fine. What about the change to only show batch actions if >1 files are selected? |
I personally really like the UX when only showing batch actions if >1 files are selected. I think we had a reason against it, but I don't remember. Do you @tbsbdr ? |
sry, me neither. jep, should still go with the "Only show batch actions for more than one selected resource" approach. |
|
I think I just never followed on with this PR fearing the huge pains when having to fix acceptance tests 🥴 hope someone else can pick up my changes and finish them for good? |
|
This has been superseded by #7904. Tests were indeed unpleasant to fix :D |
Description
Kinda experimentalnow that #6662 got merged this can be easily continuedNote: AppBar/SizeInfo/BatchAction unit tests need a major overhaul before this can get merged
Related Issue
Motivation and Context
Reduce "jumpiness" of UI, only show batch actions above files table when relevant
TO-DOs