Logout in oc10 while click logout in web #6939
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
| router.push({ name: 'login' }) | ||
| } | ||
|
|
||
| // Remove signed in user |
There was a problem hiding this comment.
Don't we need the store cleanups before the redirect?
There was a problem hiding this comment.
Well, this is something I can't answer yet, we do a redirect, so I thought the store should be cleaned while accessing the page the next time.
I moved this code path, as there is already a redirect happening in one of these dispatched actions
|
Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/25502/67/1 |
| if (options.clearOIDCLoginState) { | ||
| // clear oidc client state | ||
| vueAuthInstance.clearLoginState() | ||
| } |
There was a problem hiding this comment.
@kulmann this code path triggers a redirect already and interferes with redirecting to the oc10 log out,
I don't call vueAuthInstance.clearLoginState()anymore if we are logged in via oauth2, is this ok?
There was a problem hiding this comment.
Is it really sufficient for oauth2 to skip that step? o_O
|
Kudos, SonarCloud Quality Gate passed! |
|
Pulled latest from master to test this, after logging out of Web, if you then log in with different credentials, you are still logged in as previous user. |
|
Fixed by adding |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: