Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit user personal quota #7182

Merged
merged 9 commits into from
Aug 12, 2022
Merged

Edit user personal quota #7182

merged 9 commits into from
Aug 12, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jun 27, 2022 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jun 27, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

89.8% 89.8% Coverage
0.0% 0.0% Duplication

@kulmann
Copy link
Member

kulmann commented Aug 1, 2022

As far as I know this PR is on hold because some backend changes are to be done first. @janackermann do you have an updated status on that?

@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Aug 1, 2022 •
edited
Loading

@kulmann still waiting for the backend implementation, checked last week

@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Aug 8, 2022 •
edited
Loading

WIP, last blocker owncloud/ocis#4328
RESOLVED

@AlexAndBear AlexAndBear marked this pull request as ready for review August 8, 2022 20:51
@AlexAndBear AlexAndBear marked this pull request as draft August 8, 2022 21:16
@ownclouders
Copy link
Contributor

ownclouders commented Aug 8, 2022 •
edited
Loading

Results for oCISSharingAutocompletion https://drone.owncloud.com/owncloud/web/27467/63/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingAutocompletion-shareAutocompletionSpecialChars_feature-L43.png

webUISharingAutocompletion-shareAutocompletionSpecialChars_feature-L43.png

webUISharingAutocompletion-shareAutocompletionSpecialChars_feature-L78.png

webUISharingAutocompletion-shareAutocompletionSpecialChars_feature-L78.png

webUISharingAutocompletion-shareAutocompletionSpecialChars_feature-L79.png

webUISharingAutocompletion-shareAutocompletionSpecialChars_feature-L79.png

webUISharingAutocompletion-shareAutocompletionSpecialChars_feature-L80.png

webUISharingAutocompletion-shareAutocompletionSpecialChars_feature-L80.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@AlexAndBear AlexAndBear marked this pull request as ready for review August 9, 2022 11:47
@AlexAndBear
Copy link
Contributor Author

align with:
#7425

JanAckermann and others added 2 commits August 11, 2022 13:29
@fschade fschade requested review from fschade and removed request for fschade August 11, 2022 16:33
@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

72.7% 72.7% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kulmann kulmann merged commit 4ce877d into master Aug 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/7059 branch August 12, 2022 09:15
@micbar micbar mentioned this pull request Sep 12, 2022
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@tbsbdr tbsbdr Awaiting requested review from tbsbdr

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't edit personal Quota in usermanagement
4 participants
@AlexAndBear @kulmann @ownclouders @tbsbdr