[full-ci] move sidebar state into views #7559
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
| @@ -37,9 +37,9 @@ export default { | |||
| }, | |||
| inject: ['displayedItem'], | |||
| props: { | |||
| isContentDisplayed: { | |||
kulmann
force-pushed
the
move-sidebar-state-into-views
branch
from
e7254d6
to
7820836
Compare
| } | ||
| }, | ||
| setup() { | ||
| const { fileListHeaderY, selectedResourcesIds, selectedResources } = useResourcesViewDefaults< |
There was a problem hiding this comment.
decided to remove the useResourcesViewDefaults composable here, because that one now subscribes to some event bus topics - it should only be used in a view (once per view). Additionally I moved the variables and methods related to selected resources into its own composable (which is then spreaded into the useResourcesViewDefaults composable) so that we can continue to use that here. Remaining composable refs sideBarOpen (new) and fileListHeaderY (existing) have been moved to props and need to be passed down by the shared with me view.
| :available-panels="availablePanels" | ||
| :sidebar-accordions-warning-message="sidebarAccordionsWarningMessage" | ||
| :warning-message="warningMessage" |
There was a problem hiding this comment.
felt that this needs renaming ;-)
| ref="sidebar" | ||
| class="files-side-bar" | ||
| tabindex="-1" | ||
| :sidebar-active-panel="sidebarActivePanel" | ||
| :open="open" | ||
| :active-panel="activePanel" |
There was a problem hiding this comment.
namespacing the props of the sidebar component seemed unnecessary - renamed.
kulmann
force-pushed
the
move-sidebar-state-into-views
branch
from
7820836
to
417ac3d
Compare
| @@ -72,27 +77,6 @@ export const useResourcesViewDefaults = <T, TT, TU extends any[]>( | |||
| fileList.accentuateItem(payload.id) | |||
| }) | |||
|
|
|||
| const selectedResources: WritableComputedRef<Resource[]> = computed({ | |||
There was a problem hiding this comment.
moved into new composable useSelectedResources
| // return hardcoded `actions-item` in all cases once we have them. | ||
| await this.openSidebarWithPanel( | ||
| $_showActions_trigger() { | ||
| // we don't have details in the trashbin, yet. the actions panel is the default |
There was a problem hiding this comment.
added some more context to the explanation (unrelated to this PR otherwise)
|
Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/27963/69/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingPublicManagement-shareByPublicLink_feature-L89.png |
kulmann
force-pushed
the
move-sidebar-state-into-views
branch
from
417ac3d
to
7f2fbe9
Compare
kulmann
changed the title
kulmann
force-pushed
the
move-sidebar-state-into-views
branch
from
9c106b3
to
bbb87c1
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Description
This PR gets rid of the
sidebarvuex module in the files app, in favour of a composable, which has been added to theuseResourcesViewDefaultscomposable as well. This clears up some "magic state" of the sidebar component by wiring the sidebar state management into views, which then pass down thesideBarOpenandsideBarActivePanelrefs to whichever child component needs them.Motivation and Context
Works towards a clear hierarchy in views.
Types of changes
Checklist: