[full-ci] Search improvements #7599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
AHHH, this is soo nice ❤️ Can't wait to see it in the next beta release. work in progress - but feels already so nice! Screenshot.000462.mp4
|
|
Todos for this pr
|
|
Looks really nice 👍 |
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/28302/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/28302/tracing/search-in-personal-spaces-alice-2022-9-13-02-18-42.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/28302/tracing/search-in-personal-spaces-brian-2022-9-13-02-18-28.zip |
kulmann
requested changes
Sep 12, 2022
There was a problem hiding this comment.
Found some issues, see comments. Also when shrinking the viewport width the search preview behaves a bit weird, see screenshots (padding left vs right is not the same, x in search input field is misplaced, preview container overflows to the right on iphone size).
AlexAndBear
force-pushed
the
search-improvements-1
branch
from
80ec8bb
to
fe68190
Compare
kulmann
reviewed
Sep 12, 2022
packages/web-app-files/src/mixins/actions/helpers/isSearchActive.ts
Outdated
Show resolved
Hide resolved
added 18 commits
September 13, 2022 00:01
…hbin and using the search
AlexAndBear
force-pushed
the
search-improvements-1
branch
from
0be9a7a
to
7969896
Compare
|
acceptance tests doesn't work because of: owncloud/ocis#4575 |
|
Kudos, SonarCloud Quality Gate passed! |
fschade
added a commit
that referenced
this pull request
Sep 16, 2022
* Automated changelog update [skip ci] * Revert "[full-ci] Merge master into experimental (#7460)" This reverts commit 83bc21c. * Automated changelog update [skip ci] * use latest selenium images * update docs * pin selenium to 104.0-20220812 * refactor: use public link context composable in file details * fix: close app redirect to '/' if no context route name given * Hide share actions for space viewers/editors * Fix unit tests * Call update resource on file version restore (#7469) * Call update resource on file version restore * Automated changelog update [skip ci] * Bugfix: Dragging a file causes no selection (#7473) * Fix drag & drop without selection * Add changelog * Automated changelog update [skip ci] * fix: always return within detected context If we don't return within the detected context other contexts would get resolve attempts as well. * Avoid NavigationDuplicated error in console (#7472) * Improve users table layout on small screens (#7476) * Automated changelog update [skip ci] * Fix: Sidebar cripples file name which is not visible (#7475) * Fix: Sidebar cripples file name which is not visible * Automated changelog update [skip ci] * Automated changelog update [skip ci] * Bump ocis commit id for tests * Rename method to isShareModifiable * Automated changelog update [skip ci] * added test for spaces publiclink story * User management -> app template component -> add test (#7461) Add tests * Automated changelog update [skip ci] * Thumbnail service redesign (#7474) * Prevent unnecessary PROPFIND request during upload * addressed reviwe * Automated changelog update [skip ci] * [full-ci] Make ui small again (#7363) * Automated changelog update [skip ci] * ci: skip unstable link expiry test * Fix missing space image in sidebar * Fix 'Shared via'-indicator for links (#7479) * Automated changelog update [skip ci] * Automated changelog update [skip ci] * Fix line break for 'Paste here'-button * Automated changelog update [skip ci] * fix: use alias link role capability correctly * [tx] updated from transifex * Used cache bucket for short term caching * Automated changelog update [skip ci] * Right sidebar to views (#7501) * [tx] updated from transifex * Fix right sidebar content on small screens * add change log * Re-add button for resetting file selection, remove size info component * Add resource name to the WebDAV properties (#7485) * Automated changelog update [skip ci] * Automated changelog update [skip ci] * Implement an action for clearing the current selection * Fix file name for shared files in text editor * Automated changelog update [skip ci] * Add word-break (#7482) * fix: changelog item remove blank line * Automated changelog update [skip ci] * fix: preview loading in share jail * [tx] updated from transifex * Apply responsive measures to more top bar actions * Automated changelog update [skip ci] * Add a resize observer to conditionally show/hide tooltips * Prevent context menu labels from hiding * Fix sidebar loading for the current folder * Automated changelog update [skip ci] * Fix glitchy left sidebar when switching apps * Stuck after session expired (#7491) Co-authored-by: gitstart <[email protected]> * Automated changelog update [skip ci] * [tx] updated from transifex * Bump commit id for tests * update expected to fail file * Automated changelog update [skip ci] * Automated changelog update [skip ci] * Change quota handling (#7522) Change quota handling * Automated changelog update [skip ci] * Refactor code for upload nightly fail * Fix console error, while enter 0 (#7530) * Fix console error, while entering 0 * Automated changelog update [skip ci] * [full-ci] Bugfix: Paste action (keyboard) not working in project spaces (#7514) * Extend keyboard actions focus * Add global paste shortcut * Add changelog, linting, snapshots * Make ctrl+c, +v, +x global * Linting * Refactor function names * Update snapshot * Bind files-view instead of files * Update snapshots * Automated changelog update [skip ci] * [tx] updated from transifex * move to async script execution command * [tests-only] e2etest for spaces publiclink- Part2 (#7484) * added test for manager member * added test for resource link * added test for user carol * addressed review * address reviews Co-authored-by: Swikriti Tripathi <[email protected]> * [full-ci][tests-only] use oCIS from the cache used from multiple repos (#7523) * [tx] updated from transifex * add step sharing with group lint fix fix run reshare test in oc10 * Adds WEB_UI_CONFIG path in missing drone pipeline * Add default WEB_UI_CONFIG env * [tx] updated from transifex * resolve file duplicate name on creating new file (#7555) resolve unique name on creating new file * Automated changelog update [skip ci] * Only update changed data (#7538) Only patch user data if changes are detected * Automated changelog update [skip ci] * The acceptance tests pipelines now only depend on the unit tests pipelines Signed-off-by: Kiran Parajuli <[email protected]> [not-fore-merge] intenionally fail a e2e test to demonstrate the full-ci behaviour Signed-off-by: Kiran Parajuli <[email protected]> remove intentionally added failure Signed-off-by: Kiran Parajuli <[email protected]> Adress reviews Signed-off-by: Kiran Parajuli <[email protected]> * generate pipelines using matrices * fix building github comment step * move sidebar state into views * fix: add top margin to right sidebar nav section * test: unit tests for useSideBar * Add hover effect for left sidebar * refactor: rename "sidebar" folder to "sideBar" * Remove transition delay on sidebar text * feat: don't open right sidebar on scrollTo * refactor: rename more sidebar folders to sideBar * Automated changelog update [skip ci] * Adjust spacing of the files list options menu * fix flaky * go directly to share panel * [full-ci] Upgrade uppy and its packages to v3.0.0 (#7515) * Automated changelog update [skip ci] * [tx] updated from transifex * Automated changelog update [skip ci] * Spaces fixes (#7576) * fix: don't apply hover and focus nav item style to active item (#7575) * Automated changelog update [skip ci] * Bump ocis commit id to latest (#7577) * [tx] updated from transifex * Automated changelog update [skip ci] * Load groups via graph api (#7568) * Load groups via graph api * Decrease linter errors, keep commented tests warnings (#7581) * Decrease linter errors, keep commented tests warnings * [tx] updated from transifex * Replace build-web-integeration with cache * Remove restoreyarn * Enhancement: Remove clickOutside directive (#7584) * Enhancement: Remove clickOutside directive * Update changelog * remove clickOutside * Automated changelog update [skip ci] * Common search improvements (#7586) * Automated changelog update [skip ci] * Fix links capabilities checks (#7595) * Automated changelog update [skip ci] * Fix: merge shares with group and group member Sorts the list of incoming shares by path and allows merging of share with group and group member into one share through listing them next to each other * Reduce pagination options * changelog item * lint * Automated changelog update [skip ci] * [tx] updated from transifex * chore: simplify mime type checking This removes the dependency to guzzle. * fix: allow fonts path in oc10 web app * Automated changelog update [skip ci] * chore: update ODS to v14.0.0-alpha.17 * Automated changelog update [skip ci] * [full-ci] Add search support for shares (#7560) * Automated changelog update [skip ci] * Change save dialog placement (#7609) * Change save dialog placement * Remember the UI that was last selected via the application switcher (#6173) * Automated changelog update [skip ci] * Update yarn.lock file * Compare Save Dialog, simplify * Bump OCIS_COMMITID * fix: set up translations for web-client and web-pkg * [tx] updated from transifex * fix: use short language codes * Bump ocis commit id to latest * Automated changelog update [skip ci] * Automated changelog update [skip ci] * Bump ODS to 14.0.0-alpha.18 (#7626) * Bump ODS to 14.0.0-alpha.18 * Update changelog * test: update unit test snapshots Co-authored-by: Benedikt Kulmann <[email protected]> * Automated changelog update [skip ci] * Prepare v5.7.0-rc.1 * Prepare v5.7.0-rc.2 * Prepare v5.7.0-rc.3 * Prepare v5.7.0-rc.4 * Adjust expected failures after ocis bump Applying same changes as in the ocis repo that came with a reva update. * Prepare v5.7.0-rc.5 * Prepare v5.7.0-rc.6 * Prepare v5.7.0-rc.7 * Prepare v5.7.0-rc.8 * Prepare v5.7.0-rc.9 * Prepare v5.7.0-rc.10 * Prepare v5.7.0-rc.11 * fix: allow empty sortBy and sortDir in SharedWithMeSection * Prepare v5.7.0-rc.12 * Prepare v5.7.0-rc.13 * fix: load client and pkg translations in runtime * Prepare v5.7.0 final * Automated changelog update [skip ci] * Fix sidebar toggle icon * Add e2e tests for searching in personal (#7583) * Add language param (#7631) * Add language param * Add changelog * Fix linting * Automated changelog update [skip ci] * Automated changelog update [skip ci] * Include `x-oc-mtime` header in upload requests (#7630) * Automated changelog update [skip ci] * [full-ci] Fix sharesTree loading (#7580) * Fix sharesTree loading * Fix parent share fetching in sidebar * Remove logs * Minor adjustment * Add changelog item * Fix loading of share indicators * Move sharesTree loading to the sidebar component * Simplify code * Fix unit tests * Make share indicators in details panel reactive again * Fix space member loading * Fix sidebar panel opening * Remove unused method * Fix e2e tests * Apply small changes according to code review * Fix e2e tests * Import isEqual directly * Automated changelog update [skip ci] * [full-ci] Resolve upload existing folder conflict dialog (#7504) * It aint much but it kinda works * Implement "keep both" * Add changelog * remove dev leftover * Fix folder name * Add isFolder * Make file conflict dialog work * Linting * Fix folder keep both * Check for folder to already exist * remove dev leftover * Address PR issues * Use store * Provide existing files with function parameter * Add type to interface * Refactor resolve file & folder conflicts * Refactor conflict dialog * Bugfix, remove dev leftover * Simplify conflict-array structure * Fix folder upload * Add merge to folders * Ignore existing folder errors for now * Make Merge reappear if "do for all" ticked * Address PR issues * Add unittests * Add more unittests * Fix e2e upload version * Fix file overwrite acceptance tests * Address PR issues Co-authored-by: Jannik Stehle <[email protected]> * Automated changelog update [skip ci] * [tx] updated from transifex * Add step for removing manager (#7637) * Bump ocis commit id for tests * Fix 'Private link'-button alignment * Automated changelog update [skip ci] * [full-ci] Search improvements (#7599) * Fix mtime headers for tus requests * Automated changelog update [skip ci] * [full-ci] Enhancement: Make arrow-key navigation global (#7569) * Add forbidden ids * Remove old code * Linting, Unittests * Add CustomKeyBindings directive * Use data-attribute instead of directive * Custom keyboard actions searchbar * Add custom keybindings to FileLinks, FileShares, SpaceMembers * Add changelog * Update snapshots * Make all keybinds global * Update changelog * Linting, Cleanup KeyboardActions * Add keycode lib * Fix custom key bindings errors * Linting, Snapshots * DEV * Linting * Sanity test * Sanity test 2 * Sanity test 3 * Make spacebar shortcut local * Update snapshots * Address PR issues, remove dev leftover * Fix Linting * Address PR issues * Automated changelog update [skip ci] * [tx] updated from transifex * update proxy config of the deployment example * [full-ci] Migrate deny-acl UI code from CERNbox (#7191) * Migrate deny-acl UI code from CERNbox Co-authored-by: Florian Schade <[email protected]> Co-authored-by: Michael Barz <[email protected]> Co-authored-by: Benedikt Kulmann <[email protected]> * Automated changelog update [skip ci] * [tx] updated from transifex * Fix merge error Signed-off-by: Kiran Parajuli <[email protected]> Co-authored-by: Florian Schade <[email protected]> Co-authored-by: Saw-jan <[email protected]> Co-authored-by: Benedikt Kulmann <[email protected]> Co-authored-by: Jannik Stehle <[email protected]> Co-authored-by: Paul Neubauer <[email protected]> Co-authored-by: Jannik Stehle <[email protected]> Co-authored-by: Swikriti Tripathi <[email protected]> Co-authored-by: sushmita56 <[email protected]> Co-authored-by: Phil Davis <[email protected]> Co-authored-by: gitstart <[email protected]> Co-authored-by: Sushmita Poudel <[email protected]> Co-authored-by: ownClouders <[email protected]> Co-authored-by: Prarup Gurung <[email protected]> Co-authored-by: Artur Neumann <[email protected]> Co-authored-by: Dominik Schmidt <[email protected]> Co-authored-by: GitStart <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: PKiran <[email protected]> Co-authored-by: Viktor Scharf <[email protected]> Co-authored-by: amrita <[email protected]> Co-authored-by: Kiran Parajuli <[email protected]> Co-authored-by: Prarup Gurung <[email protected]> Co-authored-by: Diogo Castro <[email protected]> Co-authored-by: Elizaveta Ragozina <[email protected]> Co-authored-by: elizavetaRa <[email protected]> Co-authored-by: Pascal Wengerter <[email protected]> Co-authored-by: Swikriti Tripathi <[email protected]> Co-authored-by: Willy Kloucek <[email protected]> Co-authored-by: David Christofas <[email protected]> Co-authored-by: Michael Barz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: