Fix #7744, make logout screen nicer #7747
Conversation
|
Results for oC10Basic https://drone.owncloud.com/owncloud/web/28912/13/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUILogin-oauthLogin_feature-L41.pngwebUILogin-oauthLogin_feature-L49.png |
|
Thanks, Pascal! Polishing proposal: Same width for button and card:
login-screen width:
|
|
@pascalwengerter Thanks for working on this! This is actually pretty urgent, we need this merged today. Do you think you can apply Tobis proposal and fix the tests, or should I finish it? |
Ah damn, let me check if I can quickly fit it. You're free to work on it from 13:30 if I haven't pushed anything by then;) |
pascalwengerter
force-pushed
the
fix-7744
branch
from
1cbfb8f
to
add1d1c
Compare
|
@JammingBen please review, should be fine now |
| <oc-button | ||
| id="exitAnchor" | ||
| type="router-link" | ||
| class="oc-mt-m oc-width-large" |
There was a problem hiding this comment.
| class="oc-mt-m oc-width-large" | |
| class="oc-mt-m oc-width-medium" |
There was a problem hiding this comment.
I tried medium and it was definitely smaller than the parent (see previous comment above)
|
|
||
| We have updated the message and layout of the logout screen to make it a more pleasant user experience. | ||
|
|
||
| https://github.com/owncloud/web/pull/7748 |
There was a problem hiding this comment.
| https://github.com/owncloud/web/pull/7748 | |
| https://github.com/owncloud/web/pull/7747 |
There was a problem hiding this comment.
Hmgrpfff @kulmann can I get a force-merge if the rest of CI is happy and I fix this?
There was a problem hiding this comment.
Depends on what else has been changed 😅 noted that the CI was green just now.
| <div class="oc-login-card-wrapper oc-height-viewport oc-flex oc-flex-center oc-flex-middle"> | ||
| <div class="oc-login-card"> | ||
| <img class="oc-login-logo" :src="logoImg" alt="" :aria-hidden="true" /> | ||
| <div class="oc-login-card-body oc-width-large"> |
There was a problem hiding this comment.
@JammingBen this is already width-large (and was before I changed things) so adding medium to the parent wouldn't make sense?
There was a problem hiding this comment.
Ah sorry, then using oc-width-medium here and on the button would be the way to go:
There was a problem hiding this comment.
Alright let's go then, just a sec
Also please note that having this merged/published would include one transifex-roundtrip for fresh translations 😇 |
pascalwengerter
force-pushed
the
fix-7744
branch
from
add1d1c
to
db4abbb
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
added translations in transifex |
Description
See changelog item
Related Issue
Screenshots (if appropriate):
@tbsbdr opted for a primary button (since it's the only one on the screen, and using a different one would add extra effort to make it compatible with bright/dark mode).
Types of changes