Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Support noCache option for public links #7811

Merged
merged 5 commits into from
Oct 17, 2022
Merged

[full-ci] Support noCache option for public links #7811

merged 5 commits into from
Oct 17, 2022

Conversation

dschmidt
Copy link
Member

@dschmidt dschmidt commented Oct 17, 2022 •
edited
Loading

Description

This adds a noCache option to getFileContents and implements it for public links (for regular files it was set by default already).

Thanks to @diocas for raising the issue and providing the initial PR.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@dschmidt dschmidt mentioned this pull request Oct 17, 2022
Closed
@dschmidt dschmidt changed the title Support noCache option for public links [full-ci] Support noCache option for public links Oct 17, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit fac384a into master Oct 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the up_nocache_pl branch October 17, 2022 16:39
@micbar micbar mentioned this pull request Nov 25, 2022
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dschmidt @kulmann @diocas