-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci]Skip Shares folder related tests on ocis of moveFiles.feature #7895
Conversation
217983d
to
92e88c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@@ -102,7 +102,7 @@ Feature: move files | |||
When the user tries to move file "lorem.txt" into folder "simple-folder (2)" using the webUI | |||
Then as "Alice" file "simple-folder (2)/lorem.txt" should not exist in the server | |||
|
|||
@issue-ocis-873 | |||
@issue-ocis-873 @issue-7264 @skipOnOCIS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also add a comment here since this is skipped on ocis like other we have done previously?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SagarGi I think we discussed in the developer discussion not adding comments to the feature until it is a bug demonstration.
If the issue tag describes the reason for skipping the tests scenario and well-known changes like spaces implementation in ocis that brings some obvious differences in core and ocis. Such changes-related comments should be avoided in the feature file.
For detail information please visit this link: https://github.com/owncloud/docs-server/pull/697/files?short_path=12a0f40#diff-12a0f404a5bbbda65e50018a487cd725797106d670f4308b921d2081dc4b3516
92e88c5
to
056ad41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Kudos, SonarCloud Quality Gate passed! |
Description
This PR skipped the closed issued tagged scenario .Currently, the concept of the space is implemented in ocis which behaves differently. Shares are listed inside the shared space. So this scenario fails while uploading the folder inside the Shares directory. We have decided that we won't be adding/updating tests in Nightwatch.
For more information visit: #7264.
#6896
we discussed in the developer discussion not adding comments to the feature until it is a bug demonstration.
If the issue tag describes the reason for skipping the tests scenario and well-known changes like spaces implementation in ocis that brings some obvious differences in core and ocis. Such changes-related comments should be avoided in the feature file.
For detail information please visit this link: https://github.com/owncloud/docs-server/pull/697/files?short_path=12a0f40#diff-12a0f404a5bbbda65e50018a487cd725797106d670f4308b921d2081dc4b3516
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: