Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Skip Shares folder related tests on ocis of moveFiles.feature #7895

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Nov 1, 2022

Description

This PR skipped the closed issued tagged scenario .Currently, the concept of the space is implemented in ocis which behaves differently. Shares are listed inside the shared space. So this scenario fails while uploading the folder inside the Shares directory. We have decided that we won't be adding/updating tests in Nightwatch.
For more information visit: #7264.
#6896

we discussed in the developer discussion not adding comments to the feature until it is a bug demonstration.
If the issue tag describes the reason for skipping the tests scenario and well-known changes like spaces implementation in ocis that brings some obvious differences in core and ocis. Such changes-related comments should be avoided in the feature file.
For detail information please visit this link: https://github.com/owncloud/docs-server/pull/697/files?short_path=12a0f40#diff-12a0f404a5bbbda65e50018a487cd725797106d670f4308b921d2081dc4b3516

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@amrita-shrestha amrita-shrestha self-assigned this Nov 1, 2022
@amrita-shrestha amrita-shrestha marked this pull request as ready for review November 2, 2022 01:42
@amrita-shrestha amrita-shrestha force-pushed the removeClosedIssue3721 branch 3 times, most recently from 217983d to 92e88c5 Compare November 3, 2022 03:15
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -102,7 +102,7 @@ Feature: move files
When the user tries to move file "lorem.txt" into folder "simple-folder (2)" using the webUI
Then as "Alice" file "simple-folder (2)/lorem.txt" should not exist in the server

@issue-ocis-873
@issue-ocis-873 @issue-7264 @skipOnOCIS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add a comment here since this is skipped on ocis like other we have done previously?

Copy link
Contributor Author

@amrita-shrestha amrita-shrestha Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SagarGi I think we discussed in the developer discussion not adding comments to the feature until it is a bug demonstration.
If the issue tag describes the reason for skipping the tests scenario and well-known changes like spaces implementation in ocis that brings some obvious differences in core and ocis. Such changes-related comments should be avoided in the feature file.
For detail information please visit this link: https://github.com/owncloud/docs-server/pull/697/files?short_path=12a0f40#diff-12a0f404a5bbbda65e50018a487cd725797106d670f4308b921d2081dc4b3516

Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarcloud
Copy link

sonarcloud bot commented Nov 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@grgprarup grgprarup merged commit 24ca0b0 into master Nov 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the removeClosedIssue3721 branch November 3, 2022 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants