Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message display in text editor #8001

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Fix error message display in text editor #8001

merged 1 commit into from
Nov 21, 2022

Conversation

JammingBen
Copy link
Collaborator

Description

Error messages in and when leaving the text editor are now being displayed properly.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Nov 18, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 18, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@JammingBen
Copy link
Collaborator Author

JammingBen commented Nov 18, 2022 •
edited
Loading

I'm skipping unit tests here because the structure for mocking composables exists on master only currently. Will do that in a follow-up PR.

Edit: See #8002

@JammingBen JammingBen merged commit 4efba55 into stable-6.0 Nov 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-text-editor-error-messages branch November 21, 2022 10:31
@JammingBen JammingBen mentioned this pull request Nov 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@dschmidt dschmidt dschmidt approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JammingBen @dschmidt @AlexAndBear