[full-ci] Fix public link loading on role change #8006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results for oC10SharingPublic3 https://drone.owncloud.com/owncloud/web/30086/38/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L139.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L147.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L157.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L167.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L179.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L187.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L197.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L207.png |
JammingBen
changed the title
JammingBen
force-pushed
the
fix-public-link-role-change
branch
from
f2885fa
to
e63f51c
Compare
JammingBen
commented
Nov 21, 2022
JammingBen
force-pushed
the
fix-public-link-role-change
branch
from
7d15bb4
to
ab8d81b
Compare
kulmann
reviewed
Nov 22, 2022
packages/web-pkg/src/composables/driveResolver/useDriveResolver.ts
Outdated
Show resolved
Hide resolved
JammingBen
force-pushed
the
fix-public-link-role-change
branch
2 times, most recently
from
5e7ee95
to
b5dbbae
Compare
dschmidt
approved these changes
Nov 24, 2022
| }) | ||
|
|
||
| await wrapper.vm.$nextTick() | ||
| await wrapper.vm.$nextTick() |
There was a problem hiding this comment.
I'm afraid we need this? but it's ugly :(
There was a problem hiding this comment.
Yes, I didn't find a way around it unfortunately :/
kulmann
requested changes
Nov 24, 2022
kulmann
force-pushed
the
fix-public-link-role-change
branch
from
93f3363
to
21a41f2
Compare
kulmann
approved these changes
Nov 24, 2022
JammingBen
force-pushed
the
fix-public-link-role-change
branch
2 times, most recently
from
37206a1
to
54832be
Compare
JammingBen
force-pushed
the
fix-public-link-role-change
branch
from
54832be
to
2de8519
Compare
|
SonarCloud Quality Gate failed. |
73 tasks
49 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The loading and resolving of public links when their respective roles have changed has been fixed.
Related Issue
Uploaderrole, public is able to create(file | folder)in that folder #8003Types of changes