[tests-only][full-ci]Remove tests from expected to failure linked to closed issue #8075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
SwikritiT
commented
Dec 7, 2022
Comment on lines
-17
to
-19
| ### [sorting for files lists needs to be reimplemented](https://github.com/owncloud/ocis/issues/1179) | ||
| - [webUIFilesList/sort.feature:51](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesList/sort.feature#L51) | ||
| - [webUIFilesList/sort.feature:72](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesList/sort.feature#L72) |
There was a problem hiding this comment.
These line numbers don't point to any specific scenario but rather blank lines and data table
Maybe we don't run tests with openid connect so these were not caught
SwikritiT
requested review from
SagarGi,
phil-davis,
saw-jan and
amrita-shrestha
saw-jan
approved these changes
Dec 8, 2022
delete-merged-branch
bot
deleted the
refactor-expected-to-fail-for-closed-issue-part-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The linked line numbers don't point to a scenario, they rather point to a blank line ad data table, so they can be removed
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: