Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only]Skip shares related tests in OCIS #8078

Merged
merged 1 commit into from
Dec 8, 2022
Merged

[tests-only]Skip shares related tests in OCIS #8078

merged 1 commit into from
Dec 8, 2022

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Dec 8, 2022 •
edited
Loading

Description

The tests are tagged notToImplementOnOCIS as they try to access shares folder for certain operation which is not possible in OCIS because of shares jail

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@SwikritiT SwikritiT mentioned this pull request Dec 8, 2022
Closed
@SwikritiT SwikritiT marked this pull request as ready for review December 8, 2022 08:22
@SwikritiT SwikritiT self-assigned this Dec 8, 2022
saw-jan
saw-jan reviewed Dec 8, 2022
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SwikritiT SwikritiT merged commit 3cc99e0 into master Dec 8, 2022
@SwikritiT SwikritiT deleted the refactor-expected-to-fail-for-closed-issue-part-4 branch December 8, 2022 09:30
@SwikritiT SwikritiT mentioned this pull request Dec 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@phil-davis phil-davis Awaiting requested review from phil-davis

@grgprarup grgprarup Awaiting requested review from grgprarup

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SwikritiT @saw-jan