Adding libsecret to cargo to get cargo login to work
#190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P-E-Meunier
force-pushed
the
master
branch
2 times, most recently
from
3b5d45f
to
1434e6d
Compare
oxalica
requested changes
Oct 8, 2024
oxalica
requested changes
Oct 9, 2024
lib/mk-aggregated.nix
Outdated
| @@ -1,4 +1,4 @@ | |||
| { lib, stdenv, symlinkJoin, pkgsTargetTarget, bash, curl }: | |||
| { lib, stdenv, symlinkJoin, pkgsTargetTarget, bash, curl, libsecret }: | |||
|
Hmm, the cross-compilation is failing because libsecret is somehow not targetPlatform-agnostic. I don't think it's intended and I'll look into it on nixpkgs later when I have time. But for now, let's explicitly use |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux, the recommended way to work with
cargo loginis via libsecret, but that requires a specific LD_LIBRARY_PATH with this overaly.This PR fixes this by adding libsecret as a runtime dependency of cargo.
Tested on Linux-aarch64.