Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Explicitly turn on tree shaking plugin by default, add option to disable #7057

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mimbrown
Copy link

@mimbrown mimbrown commented Nov 1, 2024

Closes #7031

Explicitly marks the tree shaking plugin as ON by default. Adds --disable-tree-shaking-plugin option to disable.

Copy link

graphite-app bot commented Nov 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Nov 1, 2024
@mimbrown mimbrown changed the title Explicitly turn on tree shaking plugin by default, add option to disable fix(cli): Explicitly turn on tree shaking plugin by default, add option to disable Nov 1, 2024
@github-actions github-actions bot added the C-bug Category - Bug label Nov 1, 2024
@Boshen Boshen self-requested a review November 1, 2024 13:38
@Boshen Boshen self-assigned this Nov 3, 2024
@DonIsaac
Copy link
Collaborator

DonIsaac commented Nov 4, 2024

Are we sure we want this plugin turned on by default at all?

@Boshen
Copy link
Member

Boshen commented Nov 5, 2024

I don't think so, leave this to me.

@Boshen Boshen marked this pull request as draft November 5, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area - CLI A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linter: plugin tree_shaking is enabled by default
3 participants