better nodedb pruning logic #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlesh
reviewed
Mar 9, 2020
| return false; | ||
| return not rc.IsPublicRouter(); | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
This logic will run if we haven't received the whitelist yet. Will that cause everything to be removed in this case? That would essentially mean we wipe our nodedb at startup.
There was a problem hiding this comment.
good point, adding check.
majestrate
force-pushed
the
prune-nodedb-as-client-2020-03-08
branch
from
404dd91
to
5191af1
Compare
|
this is pretty important we should get this merged before rc3 |
jagerman
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this also prunes client nodedbs so we don't have rcs from old 0.6.x net that are invalid.