Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce log verbosity when DNS RR decode fails #1174

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Reduce log verbosity when DNS RR decode fails #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llarp/dns/message.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ namespace llarp
{
if(not an.Decode(buf))
{
llarp::LogError("failed to decode answer");
llarp::LogDebug("failed to decode answer");
return false;
}
}
Expand Down
8 changes: 4 additions & 4 deletions llarp/dns/rr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,22 +58,22 @@ namespace llarp
return false;
if(!buf->read_uint16(rr_type))
{
llarp::LogError("failed to decode rr type");
llarp::LogDebug("failed to decode rr type");
return false;
}
if(!buf->read_uint16(rr_class))
{
llarp::LogError("failed to decode rr class");
llarp::LogDebug("failed to decode rr class");
return false;
}
if(!buf->read_uint32(ttl))
{
llarp::LogError("failed to decode ttl");
llarp::LogDebug("failed to decode ttl");
return false;
}
if(!DecodeRData(buf, rData))
{
llarp::LogError("failed to decode rr rdata ", *this);
llarp::LogDebug("failed to decode rr rdata ", *this);
return false;
}
return true;
Expand Down