disable accedental fec in iwp outbound messages #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlesh
reviewed
Mar 30, 2020
| @@ -13,6 +13,7 @@ namespace llarp | |||
| : m_Data{std::move(msg)} | |||
| , m_MsgID{msgid} | |||
| , m_Completed{handler} | |||
| , m_LastFlush{now} | |||
There was a problem hiding this comment.
The net effect of this seems to be that we delay transmission. IIRC, this was even reflected in measurable latency in testing. Should we revisit this?
|
On Mon, Mar 30, 2020 at 07:18:08AM -0700, Stephen Shelton wrote:
@notlesh commented on this pull request.
> @@ -13,6 +13,7 @@ namespace llarp
: m_Data{std::move(msg)}
, m_MsgID{msgid}
, m_Completed{handler}
+ , m_LastFlush{now}
The net effect of this seems to be that we delay transmission. IIRC, this was even reflected in measurable latency in testing. Should we revisit this?
I believe that the later commits fixes this delay
…
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#1194 (review)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.