Random optimizations #1797
Merged
Random optimizations #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagerman
force-pushed
the
random-optimizations
branch
from
44fab0d
to
f4c0407
Compare
We have a few cases where we're making an extra shared_ptr which we copy into a lambda, which then results in an extra unnecessary refcount decrement in the parent; this changes them to give an rvalue reference to the lambda to avoid the extra incr/decr instead. The one in Session::Pump is particularly noticeable and shows up in profiling.
We are calling time_now() a huge amount, and it is a major consumer of CPU cycles, but we don't need it: most of the time the current event loop time is enough.
jagerman
force-pushed
the
random-optimizations
branch
from
f4c0407
to
5115162
Compare
tewinget
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce some hotspots revealed in profiling.