Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing option names, make [lokid]:rpc required #2055

Merged
merged 3 commits into from
Nov 27, 2022
Merged

Fix missing option names, make [lokid]:rpc required #2055

merged 3 commits into from
Nov 27, 2022

Commits on Nov 15, 2022

  1. Fix missing option names 

    At some point between 0.9.9 and 0.9.10 we removed the printing of option
names when a value doesn't have a default, but this means the config is
littered with things like:

    # This option sets the greater foo value.

with no actual option name printed out when there is no default.

This fixes it by always printing the option name in such a case, just
with an empty value, e.g.:

    # This option sets the greater foo value.
    #big-foo=
    @jagerman
    jagerman committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    c8ce783 View commit details
    Browse the repository at this point in the history

  2. Make [lokid]:rpc setting required in SN mode 

    When running as a service node we can't do anything without a lokid rpc
URL, and we don't necessarily have a good default for it.

This makes it required so that we fail with an appropriate error message
(rather than connect timeouts) if it is not specified.
    @jagerman
    jagerman committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    68bb74a View commit details
    Browse the repository at this point in the history

  3. Make Default&Required or Required&Hidden compilation failures 

    Default & Required makes no sense: if we have a default it makes no
sense to make it required.  The previous behaviour when this was
specified was to force an (uncommented) value in the config with the
value, but this was only used in the test suite.

Required & Hidden makes no sense either: if it's required to be
specified we definitely don't want to hide it from the generated config
file.

These are now compile-time failures.
    @jagerman
    jagerman committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    f9db657 View commit details
    Browse the repository at this point in the history