Fix incorrect ObjectiveFunction usage in tests #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
odow
commented
Apr 21, 2021
| @@ -67,7 +67,7 @@ for T in UnitTestFloats | |||
| assemble!(model,P,q,[cs1;cs2;cs3], settings = settings) | |||
| res = COSMO.optimize!(model); | |||
|
|
|||
| @test res.status == :Primal_infeasible | |||
| @test res.status == :Primal_infeasible || res.status == :Max_iter_reached | |||
There was a problem hiding this comment.
@migarstka this appears to be a regression in Julia 1.6.
There was a problem hiding this comment.
It seems to me they didn't check that Julia v1.6 didn't break any package. They also broke CDDLib and Polyhedra
odow
commented
Apr 21, 2021
| @@ -30,7 +30,7 @@ IterTools = "^1" | |||
| MathOptInterface = "~0.9.16" | |||
| QDLDL = "~0.1.4" | |||
| Requires = "^1" | |||
| Reexport = "^1" | |||
| Reexport = "0.2, ^1" | |||
There was a problem hiding this comment.
This is needed because you're building the docs on Julia 1.4, and Plots needs 0.2.
|
Thanks for the fix @odow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing COSMO to fail tests on
MOI#master: https://github.com/blegat/SolverTests/runs/2401168212