Silo quotas on silo detail #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
It's in your hands @benjaminleonard 
|
david-crespo
commented
Aug 14, 2024
| return validate?.(value, values) | ||
| }, | ||
| }, | ||
| }) |
There was a problem hiding this comment.
I think NaN wasn't failing RHF's check for a required field the way you'd hope
david-crespo
commented
Aug 14, 2024
| function validateQuota(value: number) { | ||
| if (value < 0) return 'Must be at least 0' | ||
| } | ||
|
|
There was a problem hiding this comment.
This is covered by the min = 0 on NumberField. I tested it in the E2E.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Aug 16, 2024
oxidecomputer/console@17ae890...33b7a50 * [33b7a505](oxidecomputer/console@33b7a505) oxidecomputer/console#2360 * [1a2cb52d](oxidecomputer/console@1a2cb52d) oxidecomputer/console#2369 * [9e831174](oxidecomputer/console@9e831174) oxidecomputer/console#2374 * [e30f2eb8](oxidecomputer/console@e30f2eb8) oxidecomputer/console#2373 * [bb53f1b2](oxidecomputer/console@bb53f1b2) oxidecomputer/console#2371 * [29398e74](oxidecomputer/console@29398e74) oxidecomputer/console#2343 * [68e2dc89](oxidecomputer/console@68e2dc89) oxidecomputer/console#2359 * [11e29ed8](oxidecomputer/console@11e29ed8) bump omicron to latest main * [b6ed3757](oxidecomputer/console@b6ed3757) oxidecomputer/console#2370 * [af6c1f4a](oxidecomputer/console@af6c1f4a) oxidecomputer/console#2368 * [60ef745c](oxidecomputer/console@60ef745c) disallow unreachable code in ts config, fix one case of it * [3a6f815a](oxidecomputer/console@3a6f815a) oxidecomputer/console#2364 * [80b3f2f3](oxidecomputer/console@80b3f2f3) oxidecomputer/console#2366 * [dab60d9d](oxidecomputer/console@dab60d9d) oxidecomputer/console#2358 * [8e3314f1](oxidecomputer/console@8e3314f1) oxidecomputer/console#2362 * [9b5cdfa0](oxidecomputer/console@9b5cdfa0) bump TS generator for bugfix (just adds whitespace) * [07b6c151](oxidecomputer/console@07b6c151) oxidecomputer/console#2349 * [d32fddc2](oxidecomputer/console@d32fddc2) Revert "Focus confirm button instead of cancel in modals (oxidecomputer/console#2340)" * [84a1501e](oxidecomputer/console@84a1501e) oxidecomputer/console#2341 * [6615cb6b](oxidecomputer/console@6615cb6b) oxidecomputer/console#2340 * [e48b0096](oxidecomputer/console@e48b0096) delete unused vscode tasks * [22a6c50f](oxidecomputer/console@22a6c50f) tighten TypeValueCell spacing * [4eacb3d7](oxidecomputer/console@4eacb3d7) oxidecomputer/console#2338 * [f278a747](oxidecomputer/console@f278a747) oxidecomputer/console#2332 * [016ad1b4](oxidecomputer/console@016ad1b4) oxidecomputer/console#2337 * [2d1a22a2](oxidecomputer/console@2d1a22a2) oxidecomputer/console#2336 * [be0f087f](oxidecomputer/console@be0f087f) oxidecomputer/console#2329
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Aug 16, 2024
#6366) oxidecomputer/console@17ae890...33b7a50 * [33b7a505](oxidecomputer/console@33b7a505) oxidecomputer/console#2360 * [1a2cb52d](oxidecomputer/console@1a2cb52d) oxidecomputer/console#2369 * [9e831174](oxidecomputer/console@9e831174) oxidecomputer/console#2374 * [e30f2eb8](oxidecomputer/console@e30f2eb8) oxidecomputer/console#2373 * [bb53f1b2](oxidecomputer/console@bb53f1b2) oxidecomputer/console#2371 * [29398e74](oxidecomputer/console@29398e74) oxidecomputer/console#2343 * [68e2dc89](oxidecomputer/console@68e2dc89) oxidecomputer/console#2359 * [11e29ed8](oxidecomputer/console@11e29ed8) bump omicron to latest main * [b6ed3757](oxidecomputer/console@b6ed3757) oxidecomputer/console#2370 * [af6c1f4a](oxidecomputer/console@af6c1f4a) oxidecomputer/console#2368 * [60ef745c](oxidecomputer/console@60ef745c) disallow unreachable code in ts config, fix one case of it * [3a6f815a](oxidecomputer/console@3a6f815a) oxidecomputer/console#2364 * [80b3f2f3](oxidecomputer/console@80b3f2f3) oxidecomputer/console#2366 * [dab60d9d](oxidecomputer/console@dab60d9d) oxidecomputer/console#2358 * [8e3314f1](oxidecomputer/console@8e3314f1) oxidecomputer/console#2362 * [9b5cdfa0](oxidecomputer/console@9b5cdfa0) bump TS generator for bugfix (just adds whitespace) * [07b6c151](oxidecomputer/console@07b6c151) oxidecomputer/console#2349 * [d32fddc2](oxidecomputer/console@d32fddc2) Revert "Focus confirm button instead of cancel in modals (oxidecomputer/console#2340)" * [84a1501e](oxidecomputer/console@84a1501e) oxidecomputer/console#2341 * [6615cb6b](oxidecomputer/console@6615cb6b) oxidecomputer/console#2340 * [e48b0096](oxidecomputer/console@e48b0096) delete unused vscode tasks * [22a6c50f](oxidecomputer/console@22a6c50f) tighten TypeValueCell spacing * [4eacb3d7](oxidecomputer/console@4eacb3d7) oxidecomputer/console#2338 * [f278a747](oxidecomputer/console@f278a747) oxidecomputer/console#2332 * [016ad1b4](oxidecomputer/console@016ad1b4) oxidecomputer/console#2337 * [2d1a22a2](oxidecomputer/console@2d1a22a2) oxidecomputer/console#2336 * [be0f087f](oxidecomputer/console@be0f087f) oxidecomputer/console#2329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2143