attest-data messages #220
Merged
attest-data messages #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has checked 53 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 13 | 1 | 39 | 0 |
Click to see the invalid file list
- attest-data/src/messages.rs
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
labbott
force-pushed
the
attest_messages
branch
3 times, most recently
from
ec7a737
to
37d6ef5
Compare
flihp
reviewed
Jul 30, 2024
mkeeter
reviewed
Aug 2, 2024
| let header_len = hubpack::serialize(out, header)?; | ||
| let mut n = header_len; | ||
|
|
||
| let out_data_end = out.len(); |
There was a problem hiding this comment.
Nit: you can do a one-sided range out[n..] instead of out[n..out_data_end]
mkeeter
reviewed
Aug 2, 2024
| /// Unexpected command returned | ||
| UnexpectedCommand, | ||
| /// Error return from the sprot command | ||
| SprotError(SprotError), |
There was a problem hiding this comment.
Design question: because we're already supporting nested errors, should we have an error hierarchy here that matches the one in Hubris (variants for Protocol, Spi, Attest, etc) instead of putting them all in SprotError(..)?
There was a problem hiding this comment.
I went back and forth on that. We really only care about errors from Protocol Spi and Attest so it didn't seem that helpful to have a hierarchy vs. a flat error structure.
flihp
approved these changes
Aug 22, 2024
labbott
force-pushed
the
attest_messages
branch
2 times, most recently
from
60638a6
to
1df0cdb
Compare
These are designed to be sent over IPCC (communication channel between Host OS and SP)
labbott
force-pushed
the
attest_messages
branch
from
1df0cdb
to
83ca8f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.