Unused endpoints should produce a lint warning #116
Conversation
|
@smklein can I ask you to take a quick look? I think you've been in this vicinity before |
| @@ -212,8 +212,18 @@ fn do_endpoint( | |||
| }) | |||
| .collect::<Vec<_>>(); | |||
|
|
|||
| // For reasons that are not well understood unused constants that use the | |||
There was a problem hiding this comment.
Spooky, but at least we have the negative test.
| @@ -0,0 +1,11 @@ | |||
| error: constant is never used: `unused_endpoint` | |||
There was a problem hiding this comment.
Since the behavior is "constant is never used", instead of "endpoint not registered", this presumably wouldn't fire with a pub symbol, right?
(I think that's probably okay, we can't catch everything, but just checking my understanding)
There was a problem hiding this comment.
Yeah. Good catch. If the function is pub then I'm not sure there's much we can do. This is unfortunate as one is more likely to lose track of an endpoint in a larger program and one is also more likely to have endpoints in several files in larger programs.
Perhaps in the future we could consider adding endpoints to a distributed slice (https://github.com/dtolnay/linkme) to avoid manual registration entirely.
At least this change helps in simple cases as folks ramp up on Dropshot...
Fixes #114