-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Support error types other than dropshot::HttpError
#1164
Draft
hawkw
wants to merge
20
commits into
main
Choose a base branch
from
eliza/custom-error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b937d69 - Browse repository at this point
Copy the full SHA b937d69View commit details
Commits on Nov 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a6d4113 - Browse repository at this point
Copy the full SHA a6d4113View commit details -
Configuration menu - View commit details
-
Copy full SHA for 366002e - Browse repository at this point
Copy the full SHA 366002eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c1bfac - Browse repository at this point
Copy the full SHA 4c1bfacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66e115e - Browse repository at this point
Copy the full SHA 66e115eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f6cd7b - Browse repository at this point
Copy the full SHA 1f6cd7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for afb3475 - Browse repository at this point
Copy the full SHA afb3475View commit details
Commits on Nov 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e972811 - Browse repository at this point
Copy the full SHA e972811View commit details -
Configuration menu - View commit details
-
Copy full SHA for b19f539 - Browse repository at this point
Copy the full SHA b19f539View commit details -
Configuration menu - View commit details
-
Copy full SHA for 507dc18 - Browse repository at this point
Copy the full SHA 507dc18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78ecabf - Browse repository at this point
Copy the full SHA 78ecabfView commit details -
Configuration menu - View commit details
-
Copy full SHA for aae766e - Browse repository at this point
Copy the full SHA aae766eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca3c8fa - Browse repository at this point
Copy the full SHA ca3c8faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a8c2c5 - Browse repository at this point
Copy the full SHA 0a8c2c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd3cc93 - Browse repository at this point
Copy the full SHA dd3cc93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c6bcb7 - Browse repository at this point
Copy the full SHA 3c6bcb7View commit details -
add
recommended_status_code()
to dropshot errorsAs I proposed in [this comment][1]. This is intended to be used by user code that constructs its own error type from Dropshot's errors, to make it easier to get the same status codes that are used by `HttpError` when the custom user error type just structures the response differently, or only wishes to override a small subset of Dropshot errors. Perhaps this should be a trait eventually --- I'm kinda on the fence about this. We may also want to do a similar "recommended headers" thing, since some error conditions are supposed to return specific headers, like which methods are allowed for a Method Not Allowed error code, or the desired protocol to upgrade to for a 426 Upgrade Required error. While I was here, I also changed some error variants to return more correct status codes --- a bunch of stuff currently just returns 400 Bad Request when it should really return a more specific error like 426 Upgrade Required etc. [1]: #1164 (comment)
Configuration menu - View commit details
-
Copy full SHA for f54bca9 - Browse repository at this point
Copy the full SHA f54bca9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b06b58 - Browse repository at this point
Copy the full SHA 2b06b58View commit details -
Configuration menu - View commit details
-
Copy full SHA for 860ad38 - Browse repository at this point
Copy the full SHA 860ad38View commit details
Commits on Nov 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ed8614b - Browse repository at this point
Copy the full SHA ed8614bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.