Adds USDT probes to Dropshot #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds the `RequestInfo` and `ResponseInfo` structs to package information available to DTrace - Adds USDT probes `request_start` and `request_finish` - Exposes the probes in the `http_request_handle_wrap` function - Adds feature flag for optionally enabling probes - Adds notes to README about the probes, how to enable and see via DTrace
6 tasks
construction, letting the caller do it and handle failures how they see fit.
davepacheco
reviewed
Nov 5, 2021
|
Looking good! Would you also mind adding a note to the changelog? |
|
@davepacheco Yes, I'll add notes to the changelog, and thanks for the review! I'm actually planning to update this a bit, in a way we've discussed previously. I think it's a bit better to perform registration in the server construction, so that no one needs to remember to do this or change existing code to get probes, and store the result of that in a field of the server. Instead of a separate call, one can check the field to assert probes have been enabled (or behave however one chooses). |
caller - Moves the call to `usdt::register_probes()` back into the internals of building/starting a server, to ensure it's always done if possible. Information about the result of that call is stored in the `HttpServer`, so that caller's can decide how to handle failure. - Remove call to `usdt::register_probes()` in accordance with above - Adds notes about USDT probes to changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RequestInfoandResponseInfostructs to packageinformation available to DTrace
request_startandrequest_finishhttp_request_handle_wrapfunctionDTrace