Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for options method #370

Merged
merged 2 commits into from
Jun 10, 2022
Merged

allow for options method #370

merged 2 commits into from
Jun 10, 2022

Conversation

jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Jun 8, 2022

this is a method of fixing #344 in that the user has to define options on endpoints

it would be nicer if somehow these were generated but since response headers can be defined programmatically on the fly I can't think of a way to generate them, so rather this turns on the ability to add OPTIONS as a method

Signed-off-by: Jess Frazelle <[email protected]>
@jessfraz jessfraz requested review from ahl and davepacheco June 8, 2022 21:29
Copy link
Collaborator

@ahl ahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@jessfraz jessfraz merged commit 25b85d7 into main Jun 10, 2022
@jessfraz jessfraz deleted the options branch June 10, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants