Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hyper::Request from RequestContext #557

Merged
merged 50 commits into from
Jan 19, 2023
Merged

remove hyper::Request from RequestContext #557

merged 50 commits into from
Jan 19, 2023

Conversation

davepacheco
Copy link
Collaborator

@davepacheco davepacheco commented Jan 10, 2023

Depends on #556. Leaving "draft". This is still prototype-quality. It needs tests, docs, etc.

Fixes #555.

Status:

@davepacheco davepacheco changed the title remove hyper::Request from RequestExtractor remove hyper::Request from RequestContext Jan 11, 2023
@@ -0,0 +1,42 @@
// Copyright 2023 Oxide Computer Company
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was moved (but otherwise unchanged) from dropshot/src/lib.rs

Copy link
Collaborator

@ahl ahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

CHANGELOG.adoc Outdated Show resolved Hide resolved
@davepacheco davepacheco marked this pull request as ready for review January 18, 2023 17:12
Base automatically changed from exclusive-extractors to main January 18, 2023 22:53
@davepacheco davepacheco enabled auto-merge (squash) January 19, 2023 00:56
@davepacheco davepacheco merged commit 2d526b3 into main Jan 19, 2023
@davepacheco davepacheco deleted the remove-rq branch January 19, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide access to raw hyper::Request via an extractor
2 participants