Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required-without-page_token information to pagination extension #660

Merged
merged 6 commits into from
May 2, 2023

Conversation

ahl
Copy link
Collaborator

@ahl ahl commented Apr 28, 2023

Previously x-dropshot-pagination was simply the value true. Now it's an object with a field required that is an array of strings that tell us what query parameters are required to fetch the first page (i.e. when page_token is not specified).

This also cleans up some stray doc nits.

@ahl ahl requested a review from davepacheco April 28, 2023 23:55
Copy link
Collaborator

@davepacheco davepacheco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I grok correctly that there's no impact on dropshot consumers here (unless they're using the openapi extension)?

dropshot/src/lib.rs Outdated Show resolved Hide resolved
dropshot/src/lib.rs Show resolved Hide resolved
Co-authored-by: David Pacheco <[email protected]>
@ahl
Copy link
Collaborator Author

ahl commented May 2, 2023

Do I grok correctly that there's no impact on dropshot consumers here (unless they're using the openapi extension)?

Yes; that's accurate.

@ahl ahl enabled auto-merge (squash) May 2, 2023 03:42
@ahl ahl merged commit 1b67aea into main May 2, 2023
@ahl ahl deleted the pagination-info branch May 2, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants