New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement std::error::Error for HttpError #90

Merged

smklein merged 1 commit into master from err

Feb 25, 2021

Contributor

smklein commented Feb 25, 2021 •

edited

Loading

This implementation allows HttpError to be composed within a thiserror error type.


          Implement std::error::Error for HttpError

b0542a4

smklein requested a review from davepacheco

February 25, 2021 20:15

davepacheco reviewed

View reviewed changes

dropshot/src/error.rs Show resolved Hide resolved

dropshot/src/error.rs Show resolved Hide resolved

davepacheco approved these changes

View reviewed changes

smklein merged commit 346d0a8 into master

Collaborator

davepacheco commented Feb 25, 2021

I forgot -- we should update the changelog for this change as well. (Obviously it's fine if that's a follow-on PR.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet