Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a handful of clippy lints #129

Closed
wants to merge 28 commits into from
Closed

Fix a handful of clippy lints #129

wants to merge 28 commits into from

Conversation

smklein
Copy link
Contributor

@smklein smklein commented Jan 10, 2021

This is a collection of (hopefully) not too controversial fixes from Clippy.

Full caveat: Haven't tested this on real hardware, because I don't have any (yet!). I'd be interested in recommendations / docs on what to buy / from where.

There are some remaining "default" clippy lints I haven't yet patched:

These lints have been explicitly allowed when executing clippy: https://github.com/oxidecomputer/hubris/pull/128/files#diff-3989253bf9ad53a1e59393d6504c2f8c9aaa7ca7b1a30ac713f83817463b6f91R44-R50

This extends the command:

`cargo xtask check ...`

With the additional argument:

`cargo xtask check --command [check,clippy] ...`

Allowing clippy to execute on the specified package(s).
@smklein smklein requested a review from cbiffle January 10, 2021 19:55
Copy link
Contributor

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! A few questions/comments.

drv/lpc55-spi/src/main.rs Outdated Show resolved Hide resolved
kern/src/arch/arm_m.rs Outdated Show resolved Hide resolved
kern/src/arch/arm_m.rs Show resolved Hide resolved
test/test-assist/src/main.rs Outdated Show resolved Hide resolved
@smklein smklein changed the base branch from master to format January 20, 2021 14:12
Base automatically changed from format to clippy January 26, 2021 15:56
Base automatically changed from clippy to master February 8, 2021 20:36
@smklein
Copy link
Contributor Author

smklein commented Jun 24, 2022

Gonna let this one go - seems out-of-date enough to close

@smklein smklein closed this Jun 24, 2022
@smklein smklein deleted the clippy-fixes branch June 24, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants