-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a handful of clippy lints #129
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends the command: `cargo xtask check ...` With the additional argument: `cargo xtask check --command [check,clippy] ...` Allowing clippy to execute on the specified package(s).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! A few questions/comments.
The conditionally-included modules are not being automatically formatted due to: rust-lang/rustfmt#4656
Gonna let this one go - seems out-of-date enough to close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of (hopefully) not too controversial fixes from Clippy.
Full caveat: Haven't tested this on real hardware, because I don't have any (yet!). I'd be interested in recommendations / docs on what to buy / from where.
There are some remaining "default" clippy lints I haven't yet patched:
These lints have been explicitly allowed when executing clippy: https://github.com/oxidecomputer/hubris/pull/128/files#diff-3989253bf9ad53a1e59393d6504c2f8c9aaa7ca7b1a30ac713f83817463b6f91R44-R50