Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use session close function from oxide fork of yubihsm.rs. #193

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Use session close function from oxide fork of yubihsm.rs. #193

merged 1 commit into from
Apr 2, 2024

Commits on Apr 2, 2024

  1. Use session close function from oxide fork of yubihsm.rs. 

    The `Client` type previously had a `Drop` implementation that closed the
session if the Client had an open one. This seems to have caused
problems in other downstream projects and was subsequently removed:
iqlusioninc/tmkms#37
iqlusioninc/yubihsm.rs#265

The replacement was to provide a `session()` function that returns an
Arc / MutexGuard wrapped reference to the optional session. This isn't
useful for us here because we don't and AFAIK can't take ownership of
the session which we need because the Sesison::close function consumes
the session (it can't be reopened). Our solution requires an upstream
change to the `Client` type adding a `close_session` function that just
closes the session if one is open.
    @flihp
    flihp committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    648c485 View commit details
    Browse the repository at this point in the history