Add LLDP #5196
Merged
Add LLDP #5196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depending on where the lldp CLI ends up, you may also want to update the PATH via https://github.com/oxidecomputer/omicron/blob/main/smf/profile/profile#L7 |
It should already be on the PATH: |
smklein
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
lldpdaemon and CLI to the switch zone and updatessled-agentto do the basic configuration and enablement of the service.On its own, this change will not cause the switch zone to advertise or receive
lldppackets, as no interfaces are configured. That can be done using the CLI in the switch zone for testing ondogfoodand/or the colo. Adding runtime configuration bynexuswill be follow-on work.