Tweak type inference to improve TTFX #165
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was digging through the dependencies of Dynare looking for low hanging fruit to improve our ttfx.
this PR seems to save 1.2s for one of our dependencies PATHsolver because they use DataDeps in their
__init__
.here is a small sample test and the timing results of the first run in a fresh session.
on Master:
with the first commit (removing type specification):
with the both commits:
and for sake of completeness, with a simple PercompileTools block containing the same 3 lines:
But I'm not sure if it is ok to have code that runs on the first
using DataDeps
that hits the network and writes to disk.Note: I'm using
@time @eval
because@time
seems to ignore time that was spent on things like inference.@time @eval
closely matches the actual wall-time.