Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable scope in EXTENDS management #2418

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Conversation

nvuillam
Copy link
Member

@nvuillam nvuillam commented Mar 5, 2023

quick build
TEST_KEYWORDS=config

@nvuillam
Copy link
Member Author

nvuillam commented Mar 5, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.02s
✅ BASH shellcheck 6 0 0.17s
✅ BASH shfmt 6 0 0 0.43s
✅ COPYPASTE jscpd yes no 3.22s
✅ DOCKERFILE hadolint 114 0 18.91s
✅ JSON eslint-plugin-jsonc 21 0 0 2.5s
✅ JSON jsonlint 19 0 0.33s
✅ JSON v8r 21 0 13.2s
⚠️ MARKDOWN markdownlint 309 0 230 7.8s
✅ MARKDOWN markdown-link-check 309 0 6.67s
✅ MARKDOWN markdown-table-formatter 309 0 0 22.81s
✅ OPENAPI spectral 1 0 1.81s
⚠️ PYTHON bandit 184 47 2.39s
✅ PYTHON black 184 0 0 5.47s
✅ PYTHON flake8 184 0 2.68s
✅ PYTHON isort 184 0 0 0.87s
✅ PYTHON mypy 184 0 7.72s
✅ PYTHON pylint 184 0 13.41s
⚠️ PYTHON pyright 184 250 17.94s
✅ REPOSITORY checkov yes no 34.59s
✅ REPOSITORY git_diff yes no 0.42s
✅ REPOSITORY secretlint yes no 16.23s
✅ REPOSITORY trivy yes no 33.93s
✅ SPELL cspell 746 0 24.3s
✅ SPELL misspell 567 0 0 1.03s
✅ XML xmllint 3 0 0 0.43s
✅ YAML prettier 81 0 0 3.47s
✅ YAML v8r 23 0 66.71s
✅ YAML yamllint 82 0 1.32s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

quick build
TEST_KEYWORDS=config
@nvuillam nvuillam merged commit 32009e8 into main Mar 5, 2023
@nvuillam nvuillam deleted the fixes/extends-config branch March 5, 2023 16:25
@bdovaz
Copy link
Collaborator

bdovaz commented Mar 6, 2023

@nvuillam why this change? I changed it on purpose to make the assert more specific since there are more than one error that starts with "Unable to retrieve EXTENDS config file" so the assert is no longer so specific and can catch an error that is not the one you are looking for.

image

@nvuillam
Copy link
Member Author

nvuillam commented Mar 6, 2023

@bdovaz there was a bug (variable scope -> use a variable never declared), I solved it, and the test case did not work anymore... and I did not have the time ^^
If you want to put a better test, please be my guest :)

@bdovaz bdovaz mentioned this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants