Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Project as a Module #1

Closed
michaeltlombardi opened this issue Oct 26, 2016 · 2 comments
Closed

Release Project as a Module #1

michaeltlombardi opened this issue Oct 26, 2016 · 2 comments

Comments

@michaeltlombardi
Copy link
Contributor

I'd love to see this project released as a module both here (as a zip) and via the PSGallery.

This would require that the project be slightly reorganized and that a manifest be added. I'm willing to help out with this if you'd like. :)
@michaeltlombardi
Copy link
Contributor Author

michaeltlombardi commented Oct 27, 2016 •
edited
Loading

Doing this would also allow us to include the binaries separately from the main code and import them as a dependency, leveraging #requires and the manifest to make the dependency clear and available. I've reached out to Sorlov to see if we can get the source for those binaries made available or if we can get the library released to the Gallery (further easing dependence management).

Edit: To clarify, I'm suggesting that as part of this effort we currently include the binaries and psd1 in a sub-folder with the project and later we switch to using normal dependency management.

So for now, we'd place them into a \libraries\Sorlov.PowerShell inside this folder.

@oze4 oze4 closed this as completed Oct 27, 2016
@michaeltlombardi michaeltlombardi mentioned this issue Oct 27, 2016
Closed
@michaeltlombardi
Copy link
Contributor Author

Why was this issue closed? Because you're not interested in releasing as a module or because you're working on modularizing it or for another reason?

michaeltlombardi added a commit to michaeltlombardi/New-PSService that referenced this issue Oct 27, 2016
@michaeltlombardi
Reworked script into functions
7af1b7b 
+ Moves the needle towards oze4#1 by making the functionality available in module format. Project is _not_ ready for full release to the gallery without unit tests (see below).
+ Separates the creation and installation of the service binaries, closes oze4#2
+ Replaces Create-NewService script with New-ScriptAsService, closes oze4#3
+ Replaced or removed all write-host from the functions, closes oze4#5
+ Does expand on (but doesn't close out) help and examples per oze4#6
+ Does **not** include unit tests as requested in oze4#7
+ Example script and comment-based help now indicates requirement for installation to have administrator rights, closes oze4#8
+ Adds the option to sign the binary at creation, closes oze4#9
+ Removes all instances of Clear-Host, fixes oze4#10
+ Most private functions have been removed, with the arguable exception of Set-ScriptAsServiceCredential which we've made public. Closes oze4#11

Overall this update also includes an example file and documentation as well as a first run at a build script for CI at a later date.
michaeltlombardi added a commit to michaeltlombardi/New-PSService that referenced this issue Oct 27, 2016
@michaeltlombardi
Reworked script into functions
d2c581b 
+ Moves the needle towards oze4#1 by making the functionality available in module format. Project is _not_ ready for full release to the gallery without unit tests (see below).
+ Separates the creation and installation of the service binaries, closes oze4#2
+ Replaces Create-NewService script with New-ScriptAsService, closes oze4#3
+ Replaced or removed all write-host from the functions, closes oze4#5
+ Does expand on (but doesn't close out) help and examples per oze4#6
+ Does **not** include unit tests as requested in oze4#7
+ Example script and comment-based help now indicates requirement for installation to have administrator rights, closes oze4#8
+ Adds the option to sign the binary at creation, closes oze4#9
+ Removes all instances of Clear-Host, fixes oze4#10
+ Most private functions have been removed, with the arguable exception of Set-ScriptAsServiceCredential which we've made public. Closes oze4#11

Overall this update also includes an example file and documentation as well as a first run at a build script for CI at a later date.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaeltlombardi @oze4