Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail at compile time instead of link time #26

Merged

Conversation

f-michaut
Copy link
Contributor

@f-michaut f-michaut commented Dec 10, 2023

Remove the forward-declared alpaca::details::to_bytes for non-aggregate types, since each supported type will have it's specialization included from the many alpaca/details/* headers,
it is redundant for defined types.

It is also tricking the compiler into thinking the function exist for every non-aggregate type, which leads to no compile-time error, but a linker error at the end.

Removing it will provide faster feedback to developpers and a more detailed error message.
Reference : #25

@p-ranav p-ranav merged commit 93f4b77 into p-ranav:master Dec 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants