Fail at compile time instead of link time #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the forward-declared
alpaca::details::to_bytes
for non-aggregate types, since each supported type will have it's specialization included from the manyalpaca/details/*
headers,it is redundant for defined types.
It is also tricking the compiler into thinking the function exist for every non-aggregate type, which leads to no compile-time error, but a linker error at the end.
Removing it will provide faster feedback to developpers and a more detailed error message.
Reference : #25