Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling without Boehm works #7

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

Pamplemousse
Copy link

Signed-off-by: Pamplemousse [email protected]

  * seems to have been fixed by NixOS#4947
  * change option name to match current `./configure` option
  * tested by succesfully running `meson compile nixexpr`

Signed-off-by: Pamplemousse <[email protected]>
@p01arst0rm
Copy link
Owner

you need to change the definition for the option you changed here :)

nix/meson_options.txt

Lines 43 to 47 in 9ea5634

option(
'with_gc',
type : 'boolean',
value : 'true',
description : 'Build nix with Boehm garbage collector')

@Pamplemousse
Copy link
Author

AFAICT, this file is indeed updated by this PR.
I don't understand which version of the file you are quoting... 🤔

@p01arst0rm
Copy link
Owner

nope, you changed with_gc to enable_gc. needs to be updated in the options file too :)

@Pamplemousse
Copy link
Author

needs to be updated in the options file too :)

Which options file are you talking about?
meson_options.txt IS updated by this PR...

@p01arst0rm
Copy link
Owner

ahh

for some reason when i went to check it wasnt updated :/ my mistake!

@p01arst0rm p01arst0rm merged commit 969ea76 into p01arst0rm:meson Jul 12, 2021
@Pamplemousse Pamplemousse deleted the disable_gc branch July 15, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants