Update jkbms_can.py #1
Merged
+11
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed single cell info emulation code. The cell info is not accurate since the BMS provices only min and max cell voltage and "middle voltage" cells remain outdated until they become min or max. But in such case, the previous min/max cell becomes outdated itself. Such emulation would just confuse users. The single cell value emulation also caused issues with other project feature which excepts that cell values are available. Apart of that, tweaked temperature sensor nr. and arbitary_id list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed single cell info emulation code.
The cell info is not accurate since the BMS provices only min and max cell voltage and "middle voltage" cells remain outdated until they become min or max. But in such case, the previous min/max cell becomes outdated itself. Such emulation would just confuse users.
The single cell value emulation also caused issues with other project feature which excepts that cell values are available.
Apart of that, tweaked temperature sensor nr. and arbitary_id list.