Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak inside p11_kit_remote_serve_tokens #524

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

ZoltanFridrich
Copy link
Contributor

@ZoltanFridrich ZoltanFridrich commented Jun 26, 2023

The address sanitizer reports a memory leak in the log when running test-server. At first I thought it was related to the test-server.sh failure but it didn't fix the test. The test-server.sh fails immediately after running p11tool and the log does not say anything.

This patch fixes the memory leak reported in the log even though the address sanitizer does not seem to care about it.

Closes #522

@ZoltanFridrich ZoltanFridrich requested a review from ueno June 26, 2023 15:37
@ZoltanFridrich ZoltanFridrich self-assigned this Jun 26, 2023
@coveralls
Copy link

coveralls commented Jun 26, 2023

Coverage Status

coverage: 69.931%. remained the same when pulling d447572 on ZoltanFridrich:zfridric_devel5 into ff485b8 on p11-glue:master.

Copy link
Member

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZoltanFridrich ZoltanFridrich merged commit 5b7977a into p11-glue:master Jun 27, 2023
12 checks passed
@ZoltanFridrich ZoltanFridrich added this to the 0.25.0 milestone Jun 28, 2023
@ZoltanFridrich ZoltanFridrich deleted the zfridric_devel5 branch October 4, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak inside p11_kit_remote_serve_tokens
3 participants