Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: add support for recursive attributes #624

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

ZoltanFridrich
Copy link
Contributor

Allow usage of recursive attributes like CKA_WRAP_TEMPLATE inside RPC protocol.

@ZoltanFridrich ZoltanFridrich self-assigned this Feb 28, 2024
@ZoltanFridrich ZoltanFridrich marked this pull request as draft February 28, 2024 13:33
p11-kit/test-rpc-message.c Fixed Show fixed Hide fixed
p11-kit/test-rpc-message.c Fixed Show fixed Hide fixed
@ZoltanFridrich
Copy link
Contributor Author

Still in progress. But at least the test_wrap_template test works together with other C_GetAttributeValue tests

@ZoltanFridrich ZoltanFridrich force-pushed the zfridric_devel branch 12 times, most recently from 794b796 to 8d319ea Compare March 1, 2024 12:50
@coveralls
Copy link

coveralls commented Mar 1, 2024

Coverage Status

coverage: 69.548% (+0.08%) from 69.472%
when pulling 15546bc on ZoltanFridrich:zfridric_devel
into 935e285 on p11-glue:master.

@ZoltanFridrich ZoltanFridrich marked this pull request as ready for review March 1, 2024 13:06
@ZoltanFridrich ZoltanFridrich force-pushed the zfridric_devel branch 7 times, most recently from a716350 to ae80d90 Compare March 6, 2024 09:41
p11-kit/test-mock.c Fixed Show fixed Hide fixed
@ZoltanFridrich ZoltanFridrich force-pushed the zfridric_devel branch 3 times, most recently from 4f7b1f0 to 406c593 Compare March 6, 2024 13:55
@ZoltanFridrich
Copy link
Contributor Author

The basic functionality seems to be working but it will probably require more rigorous testing. Especially in test-attrs

@ZoltanFridrich ZoltanFridrich requested a review from ueno March 6, 2024 14:01
@ZoltanFridrich ZoltanFridrich force-pushed the zfridric_devel branch 5 times, most recently from 34a9377 to 01c144a Compare March 7, 2024 15:42
p11-kit/rpc-server.c Outdated Show resolved Hide resolved
Copy link
Member

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a clean fix, thank you!

common/persist.c Show resolved Hide resolved
@ZoltanFridrich ZoltanFridrich merged commit ebfc19c into p11-glue:master Mar 12, 2024
14 checks passed
@ZoltanFridrich ZoltanFridrich added this to the 0.25.4 milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants